Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runner): handle module loaders with default exports #10541

Merged
merged 2 commits into from
Sep 21, 2020

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Sep 21, 2020

Summary

Useful for people with custom runtimes (a la #10540 (comment))

Test plan

Green CI

@@ -106,13 +106,17 @@ async function runTestInternal(
const TestEnvironment: typeof JestEnvironment = interopRequireDefault(
require(testEnvironment),
).default;
const testFramework: TestFramework =
const testFramework: TestFramework = interopRequireDefault(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can use import() here with built-in interop, but that creates extra promises 🤷 Also not sure if that works with real ESM

@SimenB SimenB merged commit 6499deb into jestjs:master Sep 21, 2020
@SimenB SimenB deleted the handle-module-loader-with-default-export branch September 21, 2020 18:57
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants