[feature] Add package to create cache key functions #10587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpojer
commented
Oct 5, 2020
| @@ -0,0 +1 @@ | |||
| [] | |||
There was a problem hiding this comment.
Note that an empty .watchmanconfig on an FB-laptop will actually not work, and crashes everything. I'm making this update in this diff so that FB engineers can develop Jest in peace :)
SimenB
reviewed
Oct 5, 2020
|
Updated with all the review comments addressed 👍 |
SimenB
approved these changes
Oct 5, 2020
SimenB
reviewed
Oct 5, 2020
This was referenced Nov 17, 2020
This was referenced Mar 29, 2021
|
Hi, is there any documentation on how to use this package? The docs mention that it's recommended, but the package has no README. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently we use an
fbjs-scriptspackage to create a cache-key function that our Jest transformers use. This is useful as it de-duplicates a bunch of work we'd otherwise have to do across repos and makes sure people don't run into stale caches, see https://github.com/facebook/fbjs/blob/master/packages/fbjs-scripts/jest/createCacheKeyFunction.js.However,
fbjs-scriptsis bad because it pulls in a ton of modules and it turns out within the React Native monorepo at FB, we only want this one module that doesn't have any dependencies. This PR adds this file as a standalone package to the Jest package, including tests.Test plan
Added a JavaScript test + types.