fix(jest-resolve-dependencies): resolve mocks as dependencies #10713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Simen Bekkhus <sbekkhus91@gmail.com>
…p/jest into brapifra/resolve-mock-dependencies
SimenB
approved these changes
Oct 26, 2020
packages/jest-resolve-dependencies/src/__tests__/dependency_resolver.test.ts
Outdated
Show resolved
Hide resolved
brapifra
commented
Oct 26, 2020
SimenB
approved these changes
Oct 26, 2020
jeysal
reviewed
Oct 26, 2020
| resolvedMockDependency = path.resolve(resolvedMockDependency); | ||
|
|
||
| // make sure mock is in the correct directory | ||
| if (dependencyMockDir === path.dirname(resolvedMockDependency)) { |
There was a problem hiding this comment.
Is there a test that fails if this acc.push is unconditional?
There was a problem hiding this comment.
Yes! Both tests fail if this gets removed. Removing it would basically add an extra non-valid dependency to the list.
|
Just one question about a potentially missing test case (or maybe I missed how the existing tests would already cover it), other than that LGTM |
jeysal
changed the title
jeysal
approved these changes
Oct 27, 2020
This was referenced Oct 27, 2020
This was referenced Mar 12, 2021
Merged
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is the continuation of #8952, which solves #8907
Test plan
I've used the unit tests from the original PR. In one of them, I've added a new assertion to check that mocks of node modules are also included as dependencies.