Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: handle file URLs in dynamic imports #10744

Merged
merged 2 commits into from
Oct 30, 2020

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Oct 30, 2020

Summary

Not sure if a startsWith is the best, but it works 🤷

Test plan

Test added

@jeysal
Copy link
Contributor

jeysal commented Oct 31, 2020

"Best" is probably trying to parse as URL and looking at .protocol ^^

@SimenB
Copy link
Member Author

SimenB commented Oct 31, 2020

Node doesn't support any other protocol than file for now, but we probably should be more future proof yeah - I just don't know a good way to separate between relative paths, absolute paths (both unix style and windows) and URLs

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants