Revert "fix(expect): objectContaining should recurse into sub-objects (#10508)"
#10766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stjs#10711)" This reverts commit f84a807.
…ts (jestjs#10508)" This reverts commit 9a07781.
SimenB
commented
Nov 2, 2020
| @@ -9,7 +9,7 @@ | |||
| - `[babel-plugin-jest-hoist]` Preserve order of hoisted mock nodes within containing block ([#10536](https://github.com/facebook/jest/pull/10536)) | |||
| - `[babel-plugin-jest-hoist]` Hoist pure constants to support experimental JSX transform in hoisted mocks ([#10723](https://github.com/facebook/jest/pull/10723)) | |||
| - `[babel-preset-jest]` Update `babel-preset-current-node-syntax` to support top level await ([#10747](https://github.com/facebook/jest/pull/10747)) | |||
| - `[expect]` Stop modifying the sample in `expect.objectContaining()` ([#10711](https://github.com/facebook/jest/pull/10711)) | |||
There was a problem hiding this comment.
never released, so I just removed it. Keeping the test, tho 👍
SimenB
commented
Nov 2, 2020
| @@ -93,7 +93,14 @@ describe('caller option correctly merges from defaults and options', () => { | |||
|
|
|||
| expect(loadPartialConfig).toHaveBeenCalledTimes(1); | |||
| expect(loadPartialConfig).toHaveBeenCalledWith( | |||
| expect.objectContaining({caller: {name: 'babel-jest', ...output}}), | |||
| expect.objectContaining({ | |||
There was a problem hiding this comment.
good example of the use case of expect.objectContaining current behavior - I only care about a subset of the properties, but I care about all of their properties
should probably add a test
There was a problem hiding this comment.
added here: cda33c9 (#10766)
This was referenced Mar 1, 2021
This was referenced Mar 7, 2021
This was referenced Mar 15, 2021
This was referenced Mar 15, 2021
Merged
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #10716
Test plan
Green CI. Kept some of the tests added later for the mutation regression