Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure toContain only accepts strings when received is a string #10929

Merged
merged 2 commits into from
Dec 8, 2020

Conversation

dubzzz
Copy link
Contributor

@dubzzz dubzzz commented Dec 8, 2020

Summary

The following expectations were still passing after #10119:

expect("false").toContain(false);
expect("0").toContain(0n);

This PR ensures only strings will be accepted when received is a string itself in toContain.

Test plan

They pass before that PR:

expect("false").toContain(false);
expect("0").toContain(0n);

They do not pass now.

@dubzzz dubzzz changed the title Ensure toContain only accepts strings when received is a string Ensure toContain only accepts strings when received is a string Dec 8, 2020
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@SimenB SimenB merged commit 395e93e into jestjs:master Dec 8, 2020
@dubzzz dubzzz deleted the better-typechecks-tocontain branch December 8, 2020 09:38
@dubzzz
Copy link
Contributor Author

dubzzz commented Dec 8, 2020

Thanks 👍

jeysal added a commit to mattphillips/jest that referenced this pull request Dec 13, 2020
* master: (30 commits)
  chore: verify TS project references are correct (jestjs#10941)
  chore(deps): bump actions/setup-node from v2.1.2 to v2.1.3 (jestjs#10940)
  docs: Rectify typo in tutorialReactNative (jestjs#10930)
  chore: patch react-native jest preprocessor to avoid warning
  Ensure `toContain` only accepts strings when `received` is a string (jestjs#10929)
  chore: update lockfile after publish
  v27.0.0-next.2
  Document and test custom, async, inline snapshot matcher (jestjs#10922)
  feat(transform): pass config options through to transformer (jestjs#10926)
  chore: bump eslint-config-prettier
  chore: run prettier using eslint
  chore: update lockfile after publish
  v27.0.0-next.1
  fix: move binary file declaration from runtime to repl (jestjs#10925)
  chore(test-result): remove deprecated `sourcemap` property (jestjs#10355)
  chore: remove mapCoverage remainings; remove deprecated CLI options test (jestjs#9968)
  refactor(jest-runtime,jest-transform): add readonly for some class fields (jestjs#10918)
  chore: ensure single environment package as well
  chore: fix failing tests (jestjs#10924)
  chore: fix lint warning
  ...
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants