Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix site inline TOC for mock functions api page #11095

Merged
merged 1 commit into from
Feb 19, 2021

Conversation

slorber
Copy link
Contributor

@slorber slorber commented Feb 19, 2021

Summary

The inline TOC (in Methods section) is wrong on this page and does not look like it used to in v1.

https://jestjs.netlify.app/docs/mock-function-api

image

In v1 we had a flat structure mixing references + typescript methods:

https://jestjs.io/docs/en/mock-function-api

image

This PR fixes the issue, but also decided that it would be better to keep the non-flat structure:

image

Test plan

Preview

@netlify
Copy link

netlify bot commented Feb 19, 2021

Deploy preview for jestjs ready!

Built with commit a8ef6ce

https://deploy-preview-11095--jestjs.netlify.app

@SimenB SimenB merged commit 9aa5d18 into jestjs:jest-website-v2 Feb 19, 2021
@slorber slorber deleted the fix-toc-bug branch March 11, 2021 09:02
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants