Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not cache modules that throw during evaluation #11263

Merged
merged 2 commits into from
May 20, 2021

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Apr 2, 2021

Summary

Fixes #11259

Test plan

Test added

moduleRegistry,
);
} catch (error: unknown) {
moduleRegistry.delete(modulePath);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we do the same for mockRegistry?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point! we should 😀

Copy link
Member Author

@SimenB SimenB May 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we already do actually

https://github.com/facebook/jest/blob/57e32e99a7994dfdcca8f777a2961294919551b9/packages/jest-runtime/src/index.ts#L803-L812

or rather, we don't cache until it's loaded, so no need to clear it

@SimenB SimenB added this to the Jest 27 milestone Apr 22, 2021
@SimenB SimenB merged commit 59f42d8 into jestjs:master May 20, 2021
@SimenB SimenB deleted the cache-throwing-modules branch May 20, 2021 13:30
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

require() shouldn't be cached when the required files throws
3 participants