Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use WeakRef for tracked handles #11277

Merged
merged 1 commit into from
Apr 12, 2021
Merged

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Apr 8, 2021

Summary

Ref #11275 (comment)

/cc @jasnell, would love if you could confirm it was something like this you had in mind 🙂

Test plan

Not sure... I don't see issues using this or the current approach, but if this passes CI using a WeakRef seems better as we don't wanna keep the timer from being collected if possible.

@@ -37,9 +39,11 @@ function stackIsFromUser(stack: string) {

const alwaysActive = () => true;

const hasWeakRef = typeof WeakRef === 'function';
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added in node 14

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally 🙏

@SimenB SimenB merged commit 8a2bf4d into jestjs:master Apr 12, 2021
@SimenB SimenB deleted the handle-weak-ref branch April 12, 2021 22:37
@piranna
Copy link
Contributor

piranna commented Apr 14, 2021

This doesn't fix issue #11275, warning still is shown and when adding the flag jest gets stalled, while before in my machine it finished anyway.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants