docs(snapshot): specify how to disable prettier #11386
Conversation
jestjs#7792 suggests that Prettier is optional, but I assumed that all I needed to do was remove `prettier` from my dependencies. That still results in Jest trying to require `prettier`, causing Jest to fail. Took awhile to learn I needed to set `prettierPath` to `null` or `''`, so I added this to the docs.
|
Hi @connorjclark! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Hmm, I actually didn't think about this limitation and I don't think there's a good reason for it. We can just try to find Prettier and fall back to not using it. So IMO we should change the behavior, not the docs. any concerns @SimenB? |
|
Agreed |
|
Adding this to the milestone because it seems like a blocker to get the stable release out, inline snapshots without Prettier isn't really working without it and we even announce it in the blog post |
|
@connorjclark would you like to contribute that change or is that a little much for a first contribution? 😅 |
|
Sure, I'd like to give it a shot. I forgot about CLA requirements–I'll ask around at my workplace Monday about getting permission and update y'all then. |
|
I received approval–will take a crack at this tomorrow. |
|
(closing for #11400, since with that PR you don't need to manually set |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
#7792 suggests that Prettier is optional, but I assumed that all I needed to do was remove
prettierfrom my dependencies. That still results in Jest trying to requireprettier, causing Jest to fail. Took awhile to learn I needed to setprettierPathtonullor'', so I added this to the docs.