Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade fsevents in jest-haste-map #11428

Merged
merged 2 commits into from
May 20, 2021
Merged

Upgrade fsevents in jest-haste-map #11428

merged 2 commits into from
May 20, 2021

Conversation

JonnyBurger
Copy link
Contributor

Summary

The current version of fsevents contains bug fixes for M1 Apple Silicon chips.
Specifically, a React Native app could not be started on M1 laptops in Xcode, because of the error message Error: EMFILE: too many open files, watch. Quite a few people are affected by it, see: facebook/metro#668

Test plan

I have isolated this change and verified that upgrading fsevents is the turnkey solution.
Fast refresh, the main feature relying on file watching operations, is still working just fine.

@SimenB
Copy link
Member

SimenB commented May 20, 2021

Good stuff 👍 Please run yarn locally as well 🙂

@JonnyBurger
Copy link
Contributor Author

@SimenB done!

@SimenB SimenB merged commit cbcec7d into jestjs:master May 20, 2021
@JonnyBurger JonnyBurger deleted the patch-1 branch May 20, 2021 15:42
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants