Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update npm instructions in README #11890

Merged
merged 1 commit into from
Sep 22, 2021
Merged

chore: update npm instructions in README #11890

merged 1 commit into from
Sep 22, 2021

Conversation

joebowbeer
Copy link
Contributor

Summary

npm t[est] to test.

Test plan

README change only.

@facebook-github-bot
Copy link
Contributor

Hi @joebowbeer!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

SimenB
SimenB approved these changes Sep 22, 2021
View reviewed changes
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@SimenB SimenB changed the title Update README.md chore: update npm instructions in README Sep 22, 2021
@SimenB SimenB merged commit da7c4a4 into jestjs:main Sep 22, 2021
AndrewSouthpaw added a commit to AndrewSouthpaw/jest that referenced this pull request Sep 23, 2021
@AndrewSouthpaw
Merge branch 'main' of https://github.com/facebook/jest into docs-tra…
e001d80 
…nsform-ignore-patterns

* 'main' of https://github.com/facebook/jest: (38 commits)
  chore: update `npm` instructions in README (jestjs#11890)
  chore: force patched version of ansi-regex (jestjs#11889)
  chore: update lockfile after publish
  v27.2.1
  chore: update changelog for release
  make the syntax error message more helpful for TS users (jestjs#11807)
  fix: include path to test file in "after teardown" error (jestjs#11885)
  docs: add link to the typescript integration instructions (jestjs#11806)
  fix: properly return mocks when using jest.isolatedModules (jestjs#11882)
  chore: remove node version pinning from CI (jestjs#11866)
  chore: remove node 13 as condition in some tests (jestjs#11880)
  chore: fix typo in docs
  chore: update lockfile after publish
  v27.2.0
  chore: roll new website version
  chore: update changelog for release
  chore: update lock
  feat: support `conditions` from test environments (jestjs#11863)
  Revert "chore: remove unneeded yarn patch for react native (jestjs#11853)"
  chore: supress experimental warnings in tests
  ...
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SimenB SimenB SimenB approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joebowbeer @facebook-github-bot @SimenB