jest-environment-node: add atob and btoa
#12269
Conversation
|
Hi @aduh95! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
| @@ -82,6 +82,13 @@ class NodeEnvironment implements JestEnvironment<Timer> { | |||
| if (typeof performance !== 'undefined') { | |||
| global.performance = performance; | |||
| } | |||
| if ( | |||
| typeof atob !== 'undefined' && | |||
There was a problem hiding this comment.
Should we add a comment here that it is available in node 16 like it was done above?
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Codecov Report
@@ Coverage Diff @@
## main #12269 +/- ##
==========================================
- Coverage 67.51% 67.51% -0.01%
==========================================
Files 328 328
Lines 17246 17249 +3
Branches 5071 5072 +1
==========================================
+ Hits 11643 11645 +2
- Misses 5570 5571 +1
Partials 33 33
Continue to review full report at Codecov.
|
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
atobandbtoaare available as globals since Node.js 16.0.0, I think Jest should leave them available as well.Fixes: #12268
Test plan
Does this need tests?