Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lint): turn the ESLint rule no-useless-call on as an error #12624

Merged
merged 1 commit into from
Apr 4, 2022
Merged

chore(lint): turn the ESLint rule no-useless-call on as an error #12624

merged 1 commit into from
Apr 4, 2022

Conversation

mrazauskas
Copy link
Contributor

Following up #12601

Summary

After the mentioned PR got merged, ESLint is printing two warnings regarding the no-useless-call rule. To avoid this, I added // eslint-disable-line comments.

Perhaps it is worth to set the rule to 'error' instead of 'warn' for the future?

Test plan

Green CI.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@SimenB SimenB merged commit d873e2c into jestjs:main Apr 4, 2022
@mrazauskas mrazauskas deleted the chore-eslint-no-useless-call branch April 4, 2022 13:20
@github-actions
Copy link

github-actions bot commented May 5, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants