Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in Jest 28 upgrade docs #12693

Merged
merged 1 commit into from
Apr 20, 2022
Merged

Fix typo in Jest 28 upgrade docs #12693

merged 1 commit into from
Apr 20, 2022

Conversation

wrslatz
Copy link
Contributor

@wrslatz wrslatz commented Apr 19, 2022

Summary

Caught a small typo in the Jest 28 upgrade docs from #12633. Fixes the typo.

Test plan

N/A

@facebook-github-bot
Copy link
Contributor

Hi @wrslatz!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@mrazauskas
Copy link
Contributor

Good catch. Thanks for reading!

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! can you sign the CLA?

@wrslatz
Copy link
Contributor Author

wrslatz commented Apr 20, 2022

thanks! can you sign the CLA?

Done, sorry for the delay!

@SimenB
Copy link
Member

SimenB commented Apr 20, 2022

Are you alive, bot? 😀

@SimenB
Copy link
Member

SimenB commented Apr 20, 2022

@zpao any idea?

@SimenB SimenB closed this Apr 20, 2022
@SimenB SimenB reopened this Apr 20, 2022
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@SimenB
Copy link
Member

SimenB commented Apr 20, 2022

aha, closing and reopening worked!

@SimenB SimenB merged commit 79bbcda into jestjs:main Apr 20, 2022
@wrslatz wrslatz deleted the patch-1 branch April 20, 2022 13:59
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants