feat(jest-resolve): expose JestResolver, AsyncResolver and SyncResolver types
#12707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrazauskas
commented
Apr 21, 2022
Comment on lines
+12
to
+13
| FindNodeModuleConfig, | ||
| ResolveModuleConfig, |
There was a problem hiding this comment.
Typings for static methods of Resolver class.
SimenB
reviewed
Apr 21, 2022
| @@ -63,6 +80,7 @@ const defaultResolver: SyncResolver = (path, options) => { | |||
| return pnpResolver(path, options); | |||
| } | |||
|
|
|||
| // @ts-expect-error: TODO packageFilter typings should be fixed in @types/resolve | |||
There was a problem hiding this comment.
hah, commented before your comments showed up 🙈
There was a problem hiding this comment.
packageFilter() takes three arguments, but @types/resolve defines just two.
There was a problem hiding this comment.
👍 will you be sending a PR to DT?
There was a problem hiding this comment.
There was a problem hiding this comment.
This was referenced Apr 22, 2022
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Jest 28 does not expose typings for custom resolver, because of bundling. Before it was possible to import types from build directory.
This PR is exposing
JestResolver,AsyncResolverandSyncResolvertypes which would be very useful for authors of custom resolvers.Test plan
Type tests are added.