Add Yarn dedupe CI check #12717
Add Yarn dedupe CI check #12717
Conversation
yarn.lock
Outdated
| version: 12.12.70 | ||
| resolution: "@types/node@npm:12.12.70" | ||
| checksum: 69c193e0bce8fa914d478f829bd923ee662b220e069a2e00ffbe109f27d0b38fbf2a9fe78c99eb4d4ccb294248ff8de68019a2c7fadb032d301c6feca25f3d22 | ||
| "@types/node@npm:*, @types/node@npm:^17.0.5": |
There was a problem hiding this comment.
* should refer to 12 still (we want that to be the version used in the repo)
There was a problem hiding this comment.
could we add a resolution entry in package.json to make @types/node always resolve to v12? is this a good idea?
There was a problem hiding this comment.
now * is resolved to v17, so typescript is failing to compile.
|
BTW, will we drop node v12 support when node v12 reaches the end of life at the end of the month? @SimenB |
|
Nah, will keep it until at least this summer when 17 is eol |
do you mean the node 17 support? but what I ask is node 12's support |
|
Yeah, we'll be keeping 12 at least as long as 17 |
|
@SimenB ci is happy. please take a look again. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Add a CI check yarn duplicate.
Test plan
Green CI