chorer: add note about babel config to upgrade guide #12724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
commented
Apr 24, 2022
| @@ -7,7 +7,7 @@ Upgrading Jest from v27 to v28? This guide aims to help refactoring your configu | |||
|
|
|||
| :::info | |||
|
|
|||
| See [changelog](https://github.com/facebook/jest/blob/main/CHANGELOG.md) for the full list of changes. | |||
| See [changelog](https://github.com/facebook/jest/blob/main/CHANGELOG.md#2800) for the full list of changes. | |||
There was a problem hiding this comment.
this anchor doesn't do anything right now, but will be correct when I make the release
mrazauskas
reviewed
Apr 24, 2022
docs/UpgradingToJest28.md
Outdated
| @@ -182,3 +182,7 @@ import {jest} from '@jest/globals'; | |||
| .mockResolvedValue('default') | |||
| .mockResolvedValueOnce('first call'); | |||
| ``` | |||
|
|
|||
| ## Babel config | |||
There was a problem hiding this comment.
Perhaps could go up? Or under Configuration? The idea was to keep alphabetical order, hoping that this could help the reader. But not necessary it works as I was thinking (;
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#12689 is a gotcha when upgrading from Jest 27, so let's call it out in the upgrade guide
Test plan
🤷