chore: fix inconsistent workspace prefixes #13217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmish
force-pushed
the
fix-inconsistent-workspace-prefix
branch
from
4bc2953
to
b96d18a
Compare
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some packages in this yarn workspace depend on other packages in the same workspace. Such dependencies were present using both
workspace:*andworkspace:^workspace-style prefixes. These have the same meaning as they will effectively depend on the current version of the package from the workspace.workspace:^was several times more common in the workspace thanworkspace:*so I switched everywhere to use that.I was also able to stop ignoring these workspace-prefix dependencies in the workspace constraint checker (which checks that we use consistent versions in the workspace).
Test plan
Internal-only change.