Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: don't perform V8 instrumenting if !collectCoverage #13282

Merged
merged 3 commits into from
Oct 8, 2022
Merged

perf: don't perform V8 instrumenting if !collectCoverage #13282

merged 3 commits into from
Oct 8, 2022

Conversation

mitchhentgesspotify
Copy link
Contributor

If coverageProvider: "v8" is provided in the Jest config, then the overhead of V8 instrumenting occurs, even if collectCoverage: false.

This saves about ~100ms of Jest-invocation-time on my machine.

@facebook-github-bot
Copy link
Contributor

Hi @mitchhentgesspotify!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

SimenB
SimenB approved these changes Sep 19, 2022
View reviewed changes
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes lots of sense, thanks!

@SimenB
Copy link
Member

SimenB commented Sep 19, 2022

@mitchhentgesspotify could you sign the CLA? 🙂

@mitchhentgesspotify
Copy link
Contributor Author

Currently checking some boxes with my company so that I can get that CLA signed, I'm on it chief 😎

@SimenB
Copy link
Member

SimenB commented Sep 28, 2022

Ping? 😀

@mitchhentgesspotify
Copy link
Contributor Author

Pong 😔 I'm making progress, but I'm still "standing by" for the moment. I haven't dropped this, I promise :)

@SimenB
Copy link
Member

SimenB commented Sep 28, 2022

Cool 👍

@mitchhentgesspotify
Copy link
Contributor Author

from our side you are in the clear, and they should be able to find your name in their inbox if they need to

Sounds like the (existing) Spotify CLA with Facebook should now be updated to include my GitHub details.
I'll resolve the merge conflict, and hopefully the "CLA Check" action will be happy now 👍

@mitchhentgesspotify
Copy link
Contributor Author

Missing Contributor License Agreement!

I'm guessing that it takes a bit for updates to cla@fb.com to propagate 🤔

@SimenB
Copy link
Member

SimenB commented Sep 28, 2022

Hopefully the bot picks it up yeah. It sometimes needs a kick, but a rebase or comment usually helps, so let's see

@mitchhentgesspotify mitchhentgesspotify force-pushed the v8-coverage-perf branch 2 times, most recently from 56cab28 to f7996e7 Compare September 29, 2022 08:30
@SimenB SimenB closed this Sep 30, 2022
@SimenB SimenB reopened this Sep 30, 2022
@SimenB
Copy link
Member

SimenB commented Sep 30, 2022

maybe closing and reopening works?

@SimenB
Copy link
Member

SimenB commented Sep 30, 2022

@zpao any idea why the bot doesn't update?

@mitchhentgesspotify
Copy link
Contributor Author

I've emailed cla@fb.com early yesterday to get their perspective. I'll keep this thread updated when I get a response.

@mitchhentgesspotify
Don't perform V8 instrumenting if !collectCoverage
a8e5994 
If `coverageProvider: "v8"` is provided in the Jest config, then the
overhead of V8 instrumenting occurs, even if `collectCoverage: false`.

This saves about ~100ms of Jest-invocation-time on my machine.

Signed-off-by: Mitchell Hentges <mhentges@spotify.com>
@mitchhentgesspotify
Update CHANGELOG.md
60e10d6 
Signed-off-by: Mitchell Hentges <mhentges@spotify.com>
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@SimenB
Copy link
Member

SimenB commented Oct 8, 2022

🎉
I'll merge when I'm in front of a computer 👍

@SimenB SimenB changed the title Don't perform V8 instrumenting if !collectCoverage perf: don't perform V8 instrumenting if !collectCoverage Oct 8, 2022
@SimenB SimenB merged commit 9984ba1 into jestjs:main Oct 8, 2022
@mitchhentgesspotify mitchhentgesspotify deleted the v8-coverage-perf branch October 10, 2022 08:33
@mitchhentgesspotify
Copy link
Contributor Author

We did it 🎉
Thanks Simen!

@SimenB
Copy link
Member

SimenB commented Oct 14, 2022

https://github.com/facebook/jest/releases/tag/v29.2.0

@ms-bot ms-bot mentioned this pull request Nov 7, 2022
Closed
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SimenB SimenB SimenB approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mitchhentgesspotify @facebook-github-bot @SimenB