Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@jest/types): infer each types correctly when the table is a tuple or array #13381

Merged
merged 3 commits into from
Oct 4, 2022
Merged

fix(@jest/types): infer each types correctly when the table is a tuple or array #13381

merged 3 commits into from
Oct 4, 2022

Conversation

mrazauskas
Copy link
Contributor

From #13360 (comment)

Summary

The type of each table wasn’t inferred correctly in cases if the table was passed as a tuple or array. This PR fixes the bug.

Test plan

Type tests adjusted.

@mrazauskas
Copy link
Contributor Author

mrazauskas commented Oct 4, 2022

That was a good catch. All looks correct now:

Screenshot 2022-10-04 at 13 56 46

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay!

@SimenB SimenB merged commit 0555ba3 into jestjs:main Oct 4, 2022
@mrazauskas mrazauskas deleted the fix-each-typings branch October 4, 2022 13:29
@github-actions
Copy link

github-actions bot commented Nov 4, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants