Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct mocking of setters and getters again #13472

Merged
merged 2 commits into from
Oct 18, 2022

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Oct 18, 2022

Summary

Reverts #13398 (kinda again), but keeping tests plus a regression test for #13466.

Note that revert didn't apply cleanly (due to changes from #13440), but I think this is correct

I've kept all passing tests from #13460.

Fixes #13466

Test plan

Green CI

@SimenB SimenB changed the title fix: correct mocking of classes again fix: correct mocking of setters and getters again Oct 18, 2022
@SimenB SimenB merged commit 33f45ad into jestjs:main Oct 18, 2022
@SimenB SimenB deleted the revert-mock-changes branch October 18, 2022 15:48
@SimenB
Copy link
Member Author

SimenB commented Oct 18, 2022

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: jest-mock 29.2.0 does not allow spying on window.dispatchEvent anymore
2 participants