chore: use prettier as default formatter in vscode #13721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps contributors to use the right formatter to avoid messing up the style
|
We run prettier via ESLint - can we configure VS Code to use that? |
I'm going to do one more commit, with: To make |
Since prettier is used as the default formatter,
these setting only affects "organize import" command.
Which is what we want.
It doesn't work completely, as this:
```ts
import type {
JestHookSubscriber,
UpdateConfigCallback,
UsageData,
WatchPlugin,
} from './types';
```
will be formatted as:
```ts
import type {
JestHookSubscriber,
UpdateConfigCallback,
UsageData,
WatchPlugin // <-- comma removed
} from './types';
```
Running format doc (prettier) will fix that.
It is better than not having it.
|
Works for me 🙂 I don't use VS Code, so cannot verify |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This helps contributors to use the right formatter to avoid messing up the style.
For example, I do not use prettier as my default formatter. So when I change code and run formatter through muscle memory,
my vscode uses the default typescript formatter which mess up the styling of the code.
Test plan
None. Project config change only.