JestRuntime:-Using scriptTransformer cache in jest-runner #13735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
reviewed
Jan 6, 2023
packages/jest-runtime/src/index.ts
Outdated
| ...transformedFile, | ||
| wrapperLength: this.constructModuleWrapperStart().length, | ||
| }); | ||
| if (this._fileTransforms.get(filename)?.code !== transformedFile.code) { |
There was a problem hiding this comment.
I think you can remove this if and just always populate the cache. Then it's a single set instead of a single get and sometimes an additional set
There was a problem hiding this comment.
yeah that way we can prevent the additional set
There was a problem hiding this comment.
a set isn't more expensive than get (just the extra spread in the object). and a single set is less expensive than get and set
SimenB
requested changes
Jan 6, 2023
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
getCachekeychanges for a file depending on the particular file it is running, the jest run-time has the_fileTransformscache that it checks to call before the _scriptTransformer.transform. I am suggesting to not doing the whole cache check and rather use the_scriptTransformer.transform's cache. this way we already have a cache using thegetCacheKey, counting this, the performance wont be affected i think.Quite unsure how should i do a test for the same.