jest-environment-jsdom: Bump JSDOM to 21.x #13833
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FWIW I've opened #13825. Do you not think it should be considered breaking for consumers? I.e. if they do something weird with |
Assuming that they alligned their behavior with browsers, I would consider this a bug fix which means it doesn't warrant a SemVer MAJOR. |
|
Closing in favor of #13825 |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
JSDOM changelog
They didn't change any library API. Only bug fixes (backwards incompatible in nature) and features for their DOM implementation. Perf improvements seem significant so this is worth the upgrade in my opinion
Types update is pending review.
Test plan