Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: tweak wording when using conflicting CLI arguments #13901

Merged
merged 1 commit into from
Mar 4, 2023

Conversation

jamesbhobbs
Copy link
Contributor

How would I do this without knowing the version to change to? If instructions are in something like contributing, then consider linking to that in the PR template so theDX is much better for such a trivial PR.

In the middle of debugging engineers don't want focus broken, unnecessarily sassy cli output is funny but plainly distracting.

It's just text, you don't even need to accept the PR or my words, it's just clearer to open a PR than an issue.

@facebook-github-bot
Copy link
Contributor

Hi @benjaminhobbs!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@SimenB
Copy link
Member

SimenB commented Feb 15, 2023

I'm fine with this change 👍 Could you sign the CLA?

@jamesbhobbs
Copy link
Contributor Author

I'm fine with this change 👍 Could you sign the CLA?

@SimenB Done

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@SimenB SimenB changed the title chore: remove sassy responses chore: tweak wording when using conflicting CLI arguments Mar 4, 2023
@SimenB SimenB merged commit 679b5ad into jestjs:main Mar 4, 2023
@github-actions
Copy link

github-actions bot commented Apr 4, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2023
@jamesbhobbs jamesbhobbs deleted the sass-is-outdated branch May 3, 2023 17:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants