-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update jest-runtime #14148
Update jest-runtime #14148
Conversation
Include `columnOffset` property for `Script` allowing vscode to match the original file with the wrapped `Script` contents.
✅ Deploy Preview for jestjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! 👍
Could you add a changelog entry and sign the CLA?
Add fix description
Fixes `Expected object keys to be in ascending order. 'columnOffset' should be before 'filename'`
Could you update the failing snapshots? Seems to only be |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Include
columnOffset
property forScript
allowing vscode to match the original file with the wrappedScript
contents.Summary
When debugging inside a jest test the vscode debugger is struggling to source map variables correctly. This applies for the hover variables and any debugger console vm scripts. This issue can be solved by setting
transform
as{}
, but this comes with the side effect that now the original file can no longer be matched as the contents of the script includes the wrapper.The length of the wrapper was already being tracked when applying the transformation. This information was only never passed along to the
Script
constructor.Test plan
node docs