-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(jest-cli): Deprecation of the --init
argument
#14490
chore(jest-cli): Deprecation of the --init
argument
#14490
Conversation
✅ Deploy Preview for jestjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
@SimenB could you please add it to the Jest 30 Milestone? |
--init
argument--init
argument
--init
argument--init
argument
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
We should handle people passing it and direct them to the new command. Currently AFK, but grep-ing for |
Around here: jest/packages/jest-validate/src/validateCLIOptions.ts Lines 107 to 109 in 0b0cf73
So possibly just adding to https://github.com/jestjs/jest/blob/0b0cf73a9fd5d6ad6cbf0152da0caed3658874b7/packages/jest-config/src/Deprecated.ts |
Thanks @SimenB, I'm already trying that, the only thing that is left is that we need to keep that in Another thought is that we probably need to exit early, because this deprecation message is only a warning, and it will try to run ![]() |
I'd suggest to update It will make deprecation logic more flexible, otherwise we need to keep unnecessary code for a while |
That makes sense to me 👍 Wanna send a separate PR for that? Should be landable in 29 |
Sounds good |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
As discussed here I prepared a PR for Jest 30 with the deprecation of the
--init
flagTest plan
I checked that: