Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: patch psl to avoid deprecation warning #14502

Merged
merged 2 commits into from
Sep 10, 2023

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Sep 9, 2023

Summary

See nodejs/citgm#959 (comment)

Test plan

Green CI

@netlify
Copy link

netlify bot commented Sep 9, 2023

Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 8732499
🔍 Latest deploy log https://app.netlify.com/sites/jestjs/deploys/64fd736ce523bd000855ba4f
😎 Deploy Preview https://deploy-preview-14502--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SimenB
Copy link
Member Author

SimenB commented Sep 9, 2023

Might be better to use a patch that's checked into the repo

@SimenB SimenB merged commit e821b83 into jestjs:main Sep 10, 2023
79 of 91 checks passed
@SimenB SimenB deleted the patch-psl-to-avoid-deprecation-warning branch September 10, 2023 13:52
@SimenB SimenB mentioned this pull request Sep 12, 2023
4 tasks
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant