-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade to glob v10 #14509
chore: upgrade to glob v10 #14509
Conversation
✅ Deploy Preview for jestjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The failing Windows tests would probably be explained by changed semantics for path separators since glob v8:
https://github.com/isaacs/node-glob/blob/main/changelog.md#81
Relevant new options: windowsPathsNoEscape
and posix
.
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
This needs to wait for us dropping Node 14, but let's see what CI says for other versions.
Test plan
Green CI (eventually)