Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jest.spyOn() unit test in JestObjectAPI.md #14625

Merged
merged 6 commits into from
Dec 24, 2023
Merged

Conversation

faizanu94
Copy link
Contributor

Summary

Since the exiting unit test mentioned at https://jestjs.io/docs/jest-object#jestspyonobject-methodname-accesstype gets failed dues to play being called as function, this PR fixes the test by accessing the play method as property due to its getter definition

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 18, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@netlify
Copy link

netlify bot commented Oct 18, 2023

Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 29b350b
🔍 Latest deploy log https://app.netlify.com/sites/jestjs/deploys/6585a9da7358fc0008478183
😎 Deploy Preview https://deploy-preview-14625--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch! can you update all versions of this docs, and sign the CLA?

@SimenB
Copy link
Member

SimenB commented Dec 2, 2023

@faizanu94 instructions for CLA is in this comment: #14625 (comment)

@faizanu94
Copy link
Contributor Author

@SimenB it's done, also updated all versions of docs - thanks!

@faizanu94
Copy link
Contributor Author

@SimenB few actions encountered a resource busy or locked error - can we initiate a rerun?

@faizanu94
Copy link
Contributor Author

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! CI errors look like flake

@SimenB SimenB merged commit 5065e24 into jestjs:main Dec 24, 2023
71 of 73 checks passed
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants