Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@jest/expect-utils): exclude non-enumerable symbol in object matching #14670

Merged
merged 2 commits into from
Nov 2, 2023

Conversation

fa93hws
Copy link
Contributor

@fa93hws fa93hws commented Nov 2, 2023

Summary

Aim to solve #14669. Context is detailed in the issue.

I think it makes more sense to ignore non-enumerable fields in the object when doing the match, otherwise it may have some unexpected behavior mobx is involved.

Test plan

Unit tests has been added

Copy link

linux-foundation-easycla bot commented Nov 2, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: fa93hws / name: Eric Wang (b72b21d)
  • ✅ login: SimenB / name: Simen Bekkhus (fe4fe1e)

Copy link

netlify bot commented Nov 2, 2023

Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit fe4fe1e
🔍 Latest deploy log https://app.netlify.com/sites/jestjs/deploys/654395ca1775ff00088b8ae3
😎 Deploy Preview https://deploy-preview-14670--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@fa93hws fa93hws force-pushed the eric/expect-utils/non-enumerable-symbol branch from 7552f04 to 4f39624 Compare November 2, 2023 02:34
@fa93hws fa93hws force-pushed the eric/expect-utils/non-enumerable-symbol branch from 4f39624 to b72b21d Compare November 2, 2023 02:46
@fa93hws fa93hws changed the title exclude non-enumerable symbol in object matching fix(@jest/expect-utils): exclude non-enumerable symbol in object matching Nov 2, 2023
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you! As this just adds tests I think it's quite safe.

@SimenB SimenB merged commit 49af781 into jestjs:main Nov 2, 2023
8 of 9 checks passed
@SimenB
Copy link
Member

SimenB commented Nov 16, 2023

Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants