Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: updated toHaveBeenCalled #14853

Merged
merged 7 commits into from
May 13, 2024

Conversation

mukul-turing
Copy link
Contributor

@mukul-turing mukul-turing commented Jan 15, 2024

Summary

This modification addresses the concern raised in issue #14842. The issue highlights a redundancy in the descriptions of .toHaveBeenCalled() and .toHaveBeenCalledWith(), despite these two functions serving distinct purposes. The rationale for this change is rooted in the fact that .toHaveBeenCalled() pertains to scenarios where no function parameters are involved. Consequently, the description has been refined to accurately convey the functionality of .toHaveBeenCalled, eliminating the redundant details about arguments and aligning it more precisely with its intended purpose.

Furthermore, I have revised the descriptions in all versioned documents associated with this documentation issue.

Test plan

After revising the documentation, I executed it on the documentation website's node server to ensure that the changes were accurately reflected. The modifications were applied to Jest documentation versions Next, 29.7, 29.6, 29.5, and 29.4. The server's documentation now displays the corrected values.

Screenshot 2024-01-15 at 3 31 22 PM Screenshot 2024-01-15 at 3 27 06 PM Screenshot 2024-01-15 at 3 29 01 PM Screenshot 2024-01-15 at 3 29 19 PM Screenshot 2024-01-15 at 3 29 29 PM

Copy link

linux-foundation-easycla bot commented Jan 15, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link

netlify bot commented Jan 15, 2024

Deploy Preview for jestjs ready!

Name Link
🔨 Latest commit 86de84b
🔍 Latest deploy log https://app.netlify.com/sites/jestjs/deploys/6641b05a322c5c00086daaf4
😎 Deploy Preview https://deploy-preview-14853--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mukul-turing mukul-turing reopened this Jan 15, 2024
@SimenB
Copy link
Member

SimenB commented Jan 29, 2024

Thanks for sending a PR!

I thought this was resolved in #14847 - did we miss anything?

@mukul-turing
Copy link
Contributor Author

mukul-turing commented Jan 30, 2024

@SimenB Thanks for checking the PR, Yes this PR is fixing the issue for Next version. I think we missed that in #14847 . Do let me know, if any modifications required to this PR.

Visually,

image

Copy link

This PR is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the Stale label Apr 29, 2024
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@SimenB
Copy link
Member

SimenB commented May 12, 2024

Oh, could you sign the CLA?

@github-actions github-actions bot removed the Stale label May 12, 2024
@mukul-turing
Copy link
Contributor Author

@SimenB i have signed the CLA. Do let me know if anything else is required.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@SimenB SimenB merged commit 672dfa2 into jestjs:main May 13, 2024
31 of 32 checks passed
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants