Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: skip broken test on windows and node 21 #14968

Merged
merged 2 commits into from
Mar 16, 2024

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Mar 16, 2024

Summary

This has been failing consistently on Windows and Node 21 for a long time. Not sure how to debug this as I don't have access to a windows device...

@G-Rath you wouldn't possibly be able to debug this test, would you? 🙏

Test plan

Green CI

@SimenB SimenB enabled auto-merge (squash) March 16, 2024 10:25
Copy link

netlify bot commented Mar 16, 2024

Deploy Preview for jestjs ready!

Name Link
🔨 Latest commit 505451d
🔍 Latest deploy log https://app.netlify.com/sites/jestjs/deploys/65f580d4d1a9c20008a097a1
😎 Deploy Preview https://deploy-preview-14968--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SimenB SimenB merged commit 6b120fb into jestjs:main Mar 16, 2024
73 checks passed
@SimenB SimenB deleted the skip-test-on-windows branch March 16, 2024 12:01
@G-Rath
Copy link
Contributor

G-Rath commented Mar 16, 2024

So far I've been able to narrow it down to something introduced in v21.6.2 and that it is the ProcessWorker tests; it looks like some tests are irrelevant but also there's a lot of beforeAll and afterAlling so I think that's accurate (e.g. disabling the top test.each tests causes either of the describe.eachs to pass but not both?).

I'm not seeing anything in the changelog for v21.6.2 that sounds like it could cause this though I'm not that familiar with the internals of this package so I could easily be missing something - I'll try and dig further but let me know if you have any ideas

@SimenB
Copy link
Member Author

SimenB commented Mar 16, 2024

Thank you so much @G-Rath! If we could reduce this down to something we can report upstream, that'd be awesome. Our nightly builds against nightly v22 fails with the same error

@G-Rath
Copy link
Contributor

G-Rath commented Mar 16, 2024

I'm going to guess it's this: nodejs/node#51766 🙂

Sounds like it should get fixed in the next set of releases that update libuv

@SimenB
Copy link
Member Author

SimenB commented Mar 17, 2024

Ah, wonderful! Thanks for taking the time to dig and finding that issue 👍

Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants