Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update description for seed option #15266

Merged
merged 1 commit into from
Sep 26, 2024
Merged

update description for seed option #15266

merged 1 commit into from
Sep 26, 2024

Conversation

jzaefferer
Copy link
Contributor

Add details on how the seed, specified or not, is used by Jest internally.

Summary

Fixes docs issue described in #15060

Test plan

n/a, since this only updates docs

Copy link

linux-foundation-easycla bot commented Aug 20, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: jzaefferer / name: Jörn Zaefferer (cfbf3f3)

Copy link

netlify bot commented Aug 20, 2024

Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit cfbf3f3
🔍 Latest deploy log https://app.netlify.com/sites/jestjs/deploys/66c4542cd8c19d00088468a9
😎 Deploy Preview https://deploy-preview-15266--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SimenB
Copy link
Member

SimenB commented Aug 20, 2024

Thanks! Could you update the versioned docs as well? It was added in 29.2, so it should be in all of them

image

@jzaefferer
Copy link
Contributor Author

Ah, alright! That also explains why I didn't see the change in the deploy preview. I had to switch to "next" to see it.

Add details on how the seed, specified or not, is used by Jest internally.

Closes jestjs#15060
@jzaefferer
Copy link
Contributor Author

@jzaefferer
Copy link
Contributor Author

So I adjusted all 4 relevant versioned docs and the previews looks good. Is there something else I can do?

@jzaefferer
Copy link
Contributor Author

The issue was closed as stale by a bot. I'm not going to bother cloning it just to have an open issue.

As far as I can tell this PR is good to merge. It only changes documentation, so should be very low risk.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@SimenB SimenB merged commit 7b5e820 into jestjs:main Sep 26, 2024
73 checks passed
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants