Fixed typos, some refactoring #15344
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Deploy Preview for jestjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
sharma-shray
commented
Oct 16, 2024
| @@ -108,7 +108,7 @@ const resolveConfigPathByTraversing = ( | |||
| throw new ValidationError(...makeMultipleConfigsErrorMessage(configFiles)); | |||
| } | |||
|
|
|||
| if (configFiles.length > 0 || packageJson) { | |||
There was a problem hiding this comment.
packageJson checked earlier
There was a problem hiding this comment.
Then we don't need the ?? in the body either
There was a problem hiding this comment.
Then we don't need the
??in the body either
Yes, thanks, corrected
old var code changed to let as it is recommended to use let or const
some typos fix
SimenB
reviewed
Oct 20, 2024
Co-authored-by: Simen Bekkhus <sbekkhus91@gmail.com>
|
This PR is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 30 days. |
|
Mind signing the CLA? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan