chore: update jsdom to v26.0.0 #15473
Open
+123
−182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
✅ Deploy Preview for jestjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
andreibereczki
force-pushed
the
feature/15325
branch
from
527bf1d to
7ea9a40
Compare
|
#15417 |
|
Can anyone help with the e2e snapshot tests? <3 I've never done snapshot testing before and don't know how to fix the issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Increased version of jsdom to
^26.0.0.#15325
#15217
CVE-2024-37890
Test plan
yarn add jsdom@26.0.0
yarn add @types/jsdom@21.1.7
Not a big deal.
22 tests are failing > but they are failing for me on main as well. No additional tests failed after the change.