Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jsdom to a modern version #221

Closed
wants to merge 2 commits into from
Closed

Update jsdom to a modern version #221

wants to merge 2 commits into from

Conversation

zpao
Copy link
Contributor

@zpao zpao commented Jan 21, 2015

This isn't ready BUT I wanted to get this started. I think we should go all the way to current jsdom and skip any intermediate versions. We're just going to get stuck again unless we fix the underlying dependency issues.

  • Stop using our compat layer
    • Do we need CSSPropertyParsers?
    • Ensure HTMLMediaElement is supported upstream
    • Ensure HTMLVideoElement is supported upstream
    • Ensure fix for HTMLInputElement.checked is supported upstream (Only uncheck radios in same form jsdom/jsdom#1007)
    • Ensure fix for HTMLSelectElement and multiple selection is supported upstream
    • Add tests for the things we had in our compat layer?
  • Ensure all of FB's internal tests pass and aren't depending on old jsdom behavior

cc @domenic who may be able to answer some of the above about support (I bet I could look at changelogs/code, but I know you're interested anyway 😄). And @nhunzaker who was working on getting us to jsdom@1.5

If anybody wants to help out, let's do PRs against this branch.

Ideally we shouldn't need it. That's not completely true at this point
but we should get any of these into jsdom proper.
@domenic
Copy link

domenic commented Jan 21, 2015

\o/

We'll need PRs for HTMLMediaElement and HTMLVideoElement, but I think the form stuff should be working these days. More tests always appreciated.

I don't know what CSSPropertyParsers is really.

@zpao
Copy link
Contributor Author

zpao commented May 4, 2015

cc @DmitrySoshnikov

@DmitrySoshnikov
Copy link
Contributor

cc @ide to double-check that all dependency checkmarks mentioned here are considered in #374.

@ide
Copy link
Contributor

ide commented Jun 5, 2015

I was hoping I could get jest in a good enough state that it would pass its own tests on io.js, and then the team at FB could chip away at the compatibility layer since the suite of jest tests at FB is way bigger than anyone else's. I have no way of testing the CSS/HTML element shims myself. My motivation for io.js support was to get react-native and other OSS projects fully installing on io.js (react-native mostly does aside from the old version of jsdom), just to communicate where I'm coming from =)

@zpao
Copy link
Contributor Author

zpao commented Aug 5, 2015

0.5 uses iojs and jsdom 5.x so closing out

@zpao zpao closed this Aug 5, 2015
@cpojer cpojer deleted the jsdom-update branch August 14, 2015 20:17
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants