Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't ready BUT I wanted to get this started. I think we should go all the way to current jsdom and skip any intermediate versions. We're just going to get stuck again unless we fix the underlying dependency issues.
CSSPropertyParsers
?HTMLMediaElement
is supported upstreamHTMLVideoElement
is supported upstreamHTMLInputElement.checked
is supported upstream (Only uncheck radios in same form jsdom/jsdom#1007)HTMLSelectElement
andmultiple
selection is supported upstreamcc @domenic who may be able to answer some of the above about support (I bet I could look at changelogs/code, but I know you're interested anyway 😄). And @nhunzaker who was working on getting us to jsdom@1.5
If anybody wants to help out, let's do PRs against this branch.