Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump harmonize to 1.4.0 #257

Merged
merged 1 commit into from
Feb 17, 2015
Merged

Bump harmonize to 1.4.0 #257

merged 1 commit into from
Feb 17, 2015

Conversation

bryannaegele
Copy link

Please bump harmonize to support running in node v0.12 and iojs. This request obviously does not attempt to address all issues to fully support node v0.12 or iojs, but does allow users to install and run jest-cli in those environments. Tested in node v0.10.36, node v0.12.0, and iojs v1.2.0.

Fixes /issues/235.
Part of the work required for /issues/243.

See dcodeIO/node-harmonize/issues/1.

Bump harmonize to support running node v0.12 and iojs.
@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@DawidJanczak
Copy link

👍 This should be merged ASAP, without this the call to harmonize in jest on 0.12 causes a major memory leak (in addition to simply not working).

leebyron added a commit that referenced this pull request Feb 17, 2015
@leebyron leebyron merged commit 86acf72 into jestjs:master Feb 17, 2015
@jeffmo
Copy link
Contributor

jeffmo commented Feb 17, 2015

Just published 0.3.0 which includes this update. Thanks a ton for sending this over!

@donatasbacius
Copy link

Just an FYI - the version of harmonize included with jest@0.3.0 depends on is-iojs@1.0.0 which has a bug on Windows... (submitted a pull request). This bug prevents jest from running and renders it unusable.

@nmn
Copy link

nmn commented May 8, 2015

I'm on v0.4.1 and Jest doesn't seem to work on anything more than node 0.10.x
I tried io.js 2.0.1 and that didn't work either. (I didn't try, io 1.x)

I didn't try to use the harmony flag anywhere.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install fails with io.js
7 participants