-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collapse Watch Usage prompt after first run #3078
Conversation
Solid work. I kinda feel like we should refactor all of watch mode into having one single "state" object rather than having many variables. Namespacing should help with readability, cc @zouxuoz. |
Had the same feeling while writing that |
@@ -195,8 +201,14 @@ const watch = ( | |||
); | |||
break; | |||
case KEYS.QUESTION_MARK: | |||
if (process.env.JEST_HIDE_USAGE) { | |||
break; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It appears that the intention behind w
is the same as ?
. IMO either ?
should be removed, or they should be treated identically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, that's right, I've missed that. I think we should get rid of the question mark.
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
This PR makes watch mode collapsed after first run, so it doesn't occupy so much of vertical space. It's possible to show the usage when pressing "w".
Here's a preview:
Test plan
Need to write a test for that