Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapse Watch Usage prompt after first run #3078

Merged
merged 1 commit into from
Mar 6, 2017

Conversation

thymikee
Copy link
Collaborator

@thymikee thymikee commented Mar 6, 2017

Summary

This PR makes watch mode collapsed after first run, so it doesn't occupy so much of vertical space. It's possible to show the usage when pressing "w".

Here's a preview:

watch

Test plan

Need to write a test for that

@cpojer
Copy link
Member

cpojer commented Mar 6, 2017

Solid work.

I kinda feel like we should refactor all of watch mode into having one single "state" object rather than having many variables. Namespacing should help with readability, cc @zouxuoz.

@cpojer cpojer merged commit 2122f0d into jestjs:master Mar 6, 2017
@thymikee
Copy link
Collaborator Author

thymikee commented Mar 6, 2017

Had the same feeling while writing that

@thymikee thymikee deleted the watch-mode-more branch March 6, 2017 13:42
@@ -195,8 +201,14 @@ const watch = (
);
break;
case KEYS.QUESTION_MARK:
if (process.env.JEST_HIDE_USAGE) {
break;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears that the intention behind w is the same as ?. IMO either ? should be removed, or they should be treated identically.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, that's right, I've missed that. I think we should get rid of the question mark.

skovhus pushed a commit to skovhus/jest that referenced this pull request Apr 29, 2017
tushardhole pushed a commit to tushardhole/jest that referenced this pull request Aug 21, 2017
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants