Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Title Unification for matchers-test.js in jest-matchers package #3153

Merged
merged 2 commits into from
Mar 18, 2017
Merged

Test Title Unification for matchers-test.js in jest-matchers package #3153

merged 2 commits into from
Mar 18, 2017

Conversation

ErnestoLCortez
Copy link
Contributor

Summary

The test file for the matchers has many test titles in different formats. The purpose of this change is to unify the test titles into a consistent format. @DmitriiAbramov

Test Titles Before:
image

Test Titles After:
image

Test plan
jest ./packages/jest-matchers/src/__tests__/matchers-test.js
yarn test

@aaronabramov
Copy link
Contributor

thanks @ErnestoLCortez!
circle CI is currently failing because the snapshots for the tests need to be regenerated and added to the repo as well!
you should run jest with -u flag

you can read about snapshot testing here: https://facebook.github.io/jest/docs/snapshot-testing.html#content

@ErnestoLCortez
Copy link
Contributor Author

Thanks for the input @DmitriiAbramov. I've added the updated snapshot to this PR. Let me know if there is anything else I've missed.

@codecov-io
Copy link

Codecov Report

Merging #3153 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3153   +/-   ##
=======================================
  Coverage   60.25%   60.25%           
=======================================
  Files         159      159           
  Lines        6625     6625           
  Branches        3        3           
=======================================
  Hits         3992     3992           
  Misses       2632     2632           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e79ad74...64d5878. Read the comment docs.

@aaronabramov
Copy link
Contributor

thanks @ErnestoLCortez!

@aaronabramov aaronabramov merged commit a37ba1a into jestjs:master Mar 18, 2017
skovhus pushed a commit to skovhus/jest that referenced this pull request Apr 29, 2017
…estjs#3153)

* Update snapshots for matchers-test.js

Update snapshots for matchers-test.js

* Converted 'passes' messages to the format {pass: bool}
tushardhole pushed a commit to tushardhole/jest that referenced this pull request Aug 21, 2017
…estjs#3153)

* Update snapshots for matchers-test.js

Update snapshots for matchers-test.js

* Converted 'passes' messages to the format {pass: bool}
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants