Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Deezer to Jest users #3157

Closed
wants to merge 3 commits into from
Closed

Add Deezer to Jest users #3157

wants to merge 3 commits into from

Conversation

rlods
Copy link
Contributor

@rlods rlods commented Mar 16, 2017

Summary

Adds Deezer to the list of jest users.

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.

Copy link
Member

@cpojer cpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please insert it at the correct alphabetical location. Thank you.

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@rlods rlods closed this Mar 17, 2017
@rlods
Copy link
Contributor Author

rlods commented Mar 17, 2017

Moved to correct alphabetical location.

@rlods rlods reopened this Mar 17, 2017
@codecov-io
Copy link

Codecov Report

Merging #3157 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3157   +/-   ##
=======================================
  Coverage   60.25%   60.25%           
=======================================
  Files         159      159           
  Lines        6625     6625           
  Branches        3        3           
=======================================
  Hits         3992     3992           
  Misses       2632     2632           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e79ad74...c900590. Read the comment docs.

@cpojer
Copy link
Member

cpojer commented Mar 19, 2017

It looks like you added two entries now.

caption: 'Deezer',
image: '/jest/img/logos/deezer.png',
infoLink: 'https://www.deezer.com/',
},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's added twice. Can you please remove this entry?

@cpojer
Copy link
Member

cpojer commented Mar 25, 2017

Will reopen once it is fixed.

@cpojer cpojer closed this Mar 25, 2017
aaronabramov pushed a commit that referenced this pull request Mar 29, 2017
skovhus pushed a commit to skovhus/jest that referenced this pull request Apr 29, 2017
tushardhole pushed a commit to tushardhole/jest that referenced this pull request Aug 21, 2017
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants