no-weak-types and require-valid-file-annotation rules were added to e… #3223
Conversation
…slint-plugin-flowtype configuration
| @@ -38,6 +38,7 @@ module.exports = Object.assign({}, fbjsConfig, { | |||
| 'comma-style': [2, 'last'], | |||
| 'computed-property-spacing': [2, 'never'], | |||
| 'eol-last': [2], | |||
| 'flowtype/no-weak-types': [2], | |||
There was a problem hiding this comment.
let's not add this for now. It will result in too many errors :)
There was a problem hiding this comment.
is it reasonable to remove it or reset the value to 1 (warnings)?
There was a problem hiding this comment.
let's just remove it for now
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions. |
.eslintrc
Outdated
| @@ -2,7 +2,8 @@ | |||
| "extends": "./packages/eslint-config-fb-strict/index.js", | |||
| "parser": "babel-eslint", | |||
| "rules": { | |||
| "no-multiple-empty-lines": 1 | |||
| "no-multiple-empty-lines": 1, | |||
| "require-valid-file-annotation": 1 | |||
There was a problem hiding this comment.
also seems like this should be used with flowtype prefix
"flowtype/require-valid-file-annotation": 1
There was a problem hiding this comment.
I noticed that "flowtype/require-valid-file-annotation" didn't generate any warnings, so I'm concerned about using "flowtype/" prefix in this case.
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
thank you! |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
eslint-plugin-flowtype configuration updates
Summary
require-valid-file-annotation rule was added. The rule produces warnings.
Test plan
yarn install
./node_modules/.bin/eslint .