Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lifecycle hooks] Make afterAll hooks operate in the fashion as afterEach. #3275

Merged
merged 1 commit into from
Apr 12, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
/**
* Copyright (c) 2015-present, Facebook, Inc. All rights reserved.
*
* This source code is licensed under the BSD-style license found in the
* LICENSE file in the root directory of this source tree. An additional grant
* of patent rights can be found in the PATENTS file in the same directory.
*
* @emails oncall+jsinfra
*/
'use strict';

describe('test lifecycle hooks', () => {
const actions = [];
function pushMessage(message) {
return () => {
actions.push(message);
};
}

// Validate in an afterAll to prevent previous hooks from firing again.
// Note that when operating correctly, this afterAll will be called last.
afterAll(() => {
const expected = [
'runner beforeAll1',
'runner beforeAll2',
'runner beforeEach1',
'runner beforeEach2',
'beforeEach1',
'beforeEach2',
'outer it 1',
'afterEach2',
'afterEach1',
'runner afterEach2',
'runner afterEach1',
'runner afterAll2',
'runner afterAll1',
];

expect(actions).toEqual(expected);
});

beforeAll(pushMessage('runner beforeAll1'));
afterAll(pushMessage('runner afterAll1'));
beforeAll(pushMessage('runner beforeAll2'));
afterAll(pushMessage('runner afterAll2'));
beforeEach(pushMessage('runner beforeEach1'));
afterEach(pushMessage('runner afterEach1'));
beforeEach(pushMessage('runner beforeEach2'));
afterEach(pushMessage('runner afterEach2'));

describe('Something', () => {
beforeEach(pushMessage('beforeEach1'));
afterEach(pushMessage('afterEach1'));
beforeEach(pushMessage('beforeEach2'));
afterEach(pushMessage('afterEach2'));
it('does it 1', pushMessage('outer it 1'));
});
});
2 changes: 1 addition & 1 deletion packages/jest-jasmine2/src/jasmine/Suite.js
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ Suite.prototype.afterEach = function(fn) {
};

Suite.prototype.afterAll = function(fn) {
this.afterAllFns.push(fn);
this.afterAllFns.unshift(fn);
};

Suite.prototype.addChild = function(child) {
Expand Down