Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install react-test-render to fix Enzyme console warning #3323

Merged
merged 2 commits into from
Apr 19, 2017

Conversation

davidctj
Copy link
Contributor

Enzyme recently made a fix for console warning if we use React v15.5+ , See issue here: enzymejs/enzyme#876

To fix that, we have to install react-test-render instead of react-addons-test-utils

Warning:

 console.error node_modules/fbjs/lib/warning.js:36
    Warning: ReactTestUtils has been moved to react-dom/test-utils. Update references to remove this warning.

  console.error node_modules/fbjs/lib/warning.js:36
    Warning: Shallow renderer has been moved to react-test-renderer/shallow. Update references to remove this warning.

Summary

Test plan

Enzyme recently made a fix for console warning if we use React v15.5+ , See issue here: enzymejs/enzyme#876

To fix that, we have to install react-test-render instead of react-addons-test-utils

Warning:
``` 
 console.error node_modules/fbjs/lib/warning.js:36
    Warning: ReactTestUtils has been moved to react-dom/test-utils. Update references to remove this warning.

  console.error node_modules/fbjs/lib/warning.js:36
    Warning: Shallow renderer has been moved to react-test-renderer/shallow. Update references to remove this warning.
```
@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@cpojer
Copy link
Member

cpojer commented Apr 19, 2017

Thank you for bringing this to our attention! I changed the language a little bit to flip it around and recommend to install test utils only on older versions of React :)

@cpojer cpojer merged commit 86fe987 into jestjs:master Apr 19, 2017
@davidctj davidctj deleted the patch-1 branch April 19, 2017 13:18
skovhus pushed a commit to skovhus/jest that referenced this pull request Apr 29, 2017
* install react-test-render for removing enzyme warning

Enzyme recently made a fix for console warning if we use React v15.5+ , See issue here: enzymejs/enzyme#876

To fix that, we have to install react-test-render instead of react-addons-test-utils

Warning:
``` 
 console.error node_modules/fbjs/lib/warning.js:36
    Warning: ReactTestUtils has been moved to react-dom/test-utils. Update references to remove this warning.

  console.error node_modules/fbjs/lib/warning.js:36
    Warning: Shallow renderer has been moved to react-test-renderer/shallow. Update references to remove this warning.
```

* Update TutorialReact.md
tushardhole pushed a commit to tushardhole/jest that referenced this pull request Aug 21, 2017
* install react-test-render for removing enzyme warning

Enzyme recently made a fix for console warning if we use React v15.5+ , See issue here: enzymejs/enzyme#876

To fix that, we have to install react-test-render instead of react-addons-test-utils

Warning:
``` 
 console.error node_modules/fbjs/lib/warning.js:36
    Warning: ReactTestUtils has been moved to react-dom/test-utils. Update references to remove this warning.

  console.error node_modules/fbjs/lib/warning.js:36
    Warning: Shallow renderer has been moved to react-test-renderer/shallow. Update references to remove this warning.
```

* Update TutorialReact.md
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants