Prettier 1.2.2, refactor runCommand #3352
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3352 +/- ##
=======================================
Coverage 64.89% 64.89%
=======================================
Files 176 176
Lines 6521 6521
Branches 4 4
=======================================
Hits 4232 4232
Misses 2288 2288
Partials 1 1
Continue to review full report at Codecov.
|
| @@ -23,7 +23,7 @@ it('maps code coverage against original source', () => { | |||
|
|
|||
| const coverageMapFile = path.join( | |||
| __dirname, | |||
| '../coverage-remapping/coverage/coverage-final.json', | |||
There was a problem hiding this comment.
is it on purpose all trailing commas are gone?
There was a problem hiding this comment.
Seems, to be, it got removed from patterns in the script. Why?
thymikee
force-pushed
the
prettier-1.2.2
branch
from
5b42227
to
f178b22
Compare
thymikee
force-pushed
the
prettier-1.2.2
branch
from
50295d2
to
a5ab732
Compare
|
Rebased and disabled |
|
awesome! |
* Prettier 1.2.2, refactor runCommand * Fix test-examples * Run prettier on examples and scripts * Fix integration_tests * Disable esilnt's computed-property-spacing
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Update Prettier to 1.2.2. This required a little change in
prettier.jsscript, so be sure to check that.I've also unified
runCommand'sargsargument to always be an array, as passing a space-separated string caused problems when filename had a space in it.Test plan
CI green.