Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use iterableEquality in spy matchers #3651

Merged
merged 2 commits into from
Jun 27, 2017
Merged

Use iterableEquality in spy matchers #3651

merged 2 commits into from
Jun 27, 2017

Commits on Jun 27, 2017

  1. Use iterableEquality in spy matchers 

    While working on custom matchers to solve jestjs#3574, I found out that the cause for
not seeing this issue in `expect().toEqual()` comes from the fact that this
matcher passes the `iterableEquality` to the `equals()` function.

When I added this to the equal calls for our spy matchers as well, Immutable.js
types were properly suppored.

I'm considering this is a bug since the `toBeCalledWith()` matchers should
behave the same as the `equals()` matcher.
    @philipp-spiess
    philipp-spiess committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    f43a04a View commit details
    Browse the repository at this point in the history

  2. Add spy matchers tests using ES6 Map and Set

    @philipp-spiess
    philipp-spiess committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    4a0daf8 View commit details
    Browse the repository at this point in the history