Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup stack trace in tests #3696

Merged
merged 1 commit into from
May 31, 2017
Merged

cleanup stack trace in tests #3696

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 20 additions & 17 deletions integration_tests/__tests__/__snapshots__/failures-test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,14 +62,15 @@ Object {
Expected value to be truthy, instead received
false

at Object.throws (__tests__/assertion-count-test.js:14:17)
at __tests__/assertion-count-test.js:14:17

● .assertions() › throws

expect.assertions(2)

Expected two assertions to be called but only received one assertion call.

at ../../packages/jest-jasmine2/build/setup-jest-globals.js:68:21

● .assertions() › throws on redeclare of assertion count

Expand All @@ -78,21 +79,23 @@ Object {
Expected value to be truthy, instead received
false

at Object.redeclare (__tests__/assertion-count-test.js:18:17)
at __tests__/assertion-count-test.js:18:17

● .assertions() › throws on assertion

expect.assertions(0)

Expected zero assertions to be called but only received one assertion call.

at ../../packages/jest-jasmine2/build/setup-jest-globals.js:68:21

● .hasAssertions() › throws when there are not assertions

expect.hasAssertions()

Expected at least one assertion to be called but received none.

at ../../packages/jest-jasmine2/build/setup-jest-globals.js:88:21

.assertions()
✕ throws
Expand Down Expand Up @@ -123,7 +126,7 @@ Object {
Received:
false

at Object.<anonymous> (__tests__/node-assertion-error-test.js:16:3)
at __tests__/node-assertion-error-test.js:16:3

● assert with a message

Expand All @@ -137,7 +140,7 @@ Object {
Message:
this is a message

at Object.<anonymous> (__tests__/node-assertion-error-test.js:20:3)
at __tests__/node-assertion-error-test.js:20:3

● assert.ok

Expand All @@ -148,7 +151,7 @@ Object {
Received:
false

at Object.<anonymous> (__tests__/node-assertion-error-test.js:24:10)
at __tests__/node-assertion-error-test.js:24:10

● assert.ok with a message

Expand All @@ -162,7 +165,7 @@ Object {
Message:
this is a message

at Object.<anonymous> (__tests__/node-assertion-error-test.js:28:10)
at __tests__/node-assertion-error-test.js:28:10

● assert.equal

Expand All @@ -173,7 +176,7 @@ Object {
Received:
1

at Object.<anonymous> (__tests__/node-assertion-error-test.js:32:10)
at __tests__/node-assertion-error-test.js:32:10

● assert.notEqual

Expand All @@ -188,7 +191,7 @@ Object {

Compared values have no visual difference.

at Object.<anonymous> (__tests__/node-assertion-error-test.js:36:10)
at __tests__/node-assertion-error-test.js:36:10

● assert.deepEqual

Expand All @@ -213,7 +216,7 @@ Object {
},
}

at Object.<anonymous> (__tests__/node-assertion-error-test.js:40:10)
at __tests__/node-assertion-error-test.js:40:10

● assert.deepEqual with a message

Expand Down Expand Up @@ -241,7 +244,7 @@ Object {
},
}

at Object.<anonymous> (__tests__/node-assertion-error-test.js:44:10)
at __tests__/node-assertion-error-test.js:44:10

● assert.notDeepEqual

Expand All @@ -256,7 +259,7 @@ Object {

Compared values have no visual difference.

at Object.<anonymous> (__tests__/node-assertion-error-test.js:48:10)
at __tests__/node-assertion-error-test.js:48:10

● assert.strictEqual

Expand All @@ -267,7 +270,7 @@ Object {
Received:
1

at Object.<anonymous> (__tests__/node-assertion-error-test.js:52:10)
at __tests__/node-assertion-error-test.js:52:10

● assert.notStrictEqual

Expand All @@ -285,7 +288,7 @@ Object {

Compared values have no visual difference.

at Object.<anonymous> (__tests__/node-assertion-error-test.js:56:10)
at __tests__/node-assertion-error-test.js:56:10

● assert.deepStrictEqual

Expand All @@ -306,7 +309,7 @@ Object {
+ \\"a\\": 1,
}

at Object.<anonymous> (__tests__/node-assertion-error-test.js:60:10)
at __tests__/node-assertion-error-test.js:60:10

● assert.notDeepStrictEqual

Expand All @@ -321,7 +324,7 @@ Object {

Compared values have no visual difference.

at Object.<anonymous> (__tests__/node-assertion-error-test.js:64:10)
at __tests__/node-assertion-error-test.js:64:10

● assert.ifError

Expand All @@ -339,7 +342,7 @@ Object {
Message:
Got unwanted exception..

at Object.<anonymous> (__tests__/node-assertion-error-test.js:72:10)
at __tests__/node-assertion-error-test.js:72:10

● assert.throws

Expand All @@ -351,7 +354,7 @@ Object {
Message:
Missing expected exception..

at Object.<anonymous> (__tests__/node-assertion-error-test.js:78:10)
at __tests__/node-assertion-error-test.js:78:10

✕ assert
✕ assert with a message
Expand Down
23 changes: 5 additions & 18 deletions integration_tests/__tests__/failures-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,32 +15,19 @@ const dir = path.resolve(__dirname, '../failures');

skipOnWindows.suite();

// Some node versions add an extra line to the error stack trace. This makes
// snapshot tests fail on different machines. This function makes sure
// this extra line is always removed.
const stripInconsistentStackLines = summary => {
summary.rest = summary.rest
.replace(/\n^.*process\._tickCallback.*$/gm, '')
.replace(/\n^.*_throws.*$/gm, '')
.replace(/\n^.*Function\..*(throws|doesNotThrow).*$/gm, '')
.replace(/\n^.*setup-jest-globals\.js.*$/gm, '')
.replace(/(\n^.*Object.<anonymous>)\.test(.*$)/gm, '$1$2');
return summary;
};

test('not throwing Error objects', () => {
let stderr;
stderr = runJest(dir, ['throw-number-test.js']).stderr;
expect(stripInconsistentStackLines(extractSummary(stderr))).toMatchSnapshot();
expect(extractSummary(stderr)).toMatchSnapshot();
stderr = runJest(dir, ['throw-string-test.js']).stderr;
expect(stripInconsistentStackLines(extractSummary(stderr))).toMatchSnapshot();
expect(extractSummary(stderr)).toMatchSnapshot();
stderr = runJest(dir, ['throw-object-test.js']).stderr;
expect(stripInconsistentStackLines(extractSummary(stderr))).toMatchSnapshot();
expect(extractSummary(stderr)).toMatchSnapshot();
stderr = runJest(dir, ['assertion-count-test.js']).stderr;
expect(stripInconsistentStackLines(extractSummary(stderr))).toMatchSnapshot();
expect(extractSummary(stderr)).toMatchSnapshot();
});

test('works with node assert', () => {
const {stderr} = runJest(dir, ['node-assertion-error-test.js']);
expect(stripInconsistentStackLines(extractSummary(stderr))).toMatchSnapshot();
expect(extractSummary(stderr)).toMatchSnapshot();
});
22 changes: 20 additions & 2 deletions integration_tests/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,14 +119,32 @@ const extractSummary = stdout => {
.replace(/\d*\.?\d+m?s/g, '<<REPLACED>>')
.replace(/, estimated <<REPLACED>>/g, '');

// remove all timestamps
const rest = stdout.slice(0, -match[0].length).replace(/\s*\(.*ms\)/gm, '');
const rest = cleanupStackTrace(
// remove all timestamps
stdout.slice(0, -match[0].length).replace(/\s*\(.*ms\)/gm, ''),
);

return {rest, summary};
};

// different versions of Node print different stack traces. This function
// unifies their output to make it possible to snapshot them.
const cleanupStackTrace = (output: string) => {
return (
output
.replace(/\n.*at.*timers\.js.*$/gm, '')
.replace(/\n.*at.*assert\.js.*$/gm, '')
.replace(/\n.*at.*node\.js.*$/gm, '')
.replace(/\n.*at.*next_tick\.js.*$/gm, '')
.replace(/\n.*at Promise \(<anonymous>\).*$/gm, '')
.replace(/\n.*at <anonymous>.*$/gm, '')
.replace(/^.*at.*[\s][\(]?(\S*\:\d*\:\d*).*$/gm, ' at $1')
);
};

module.exports = {
cleanup,
cleanupStackTrace,
createEmptyPackage,
extractSummary,
fileExists,
Expand Down