Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding default locale as en. Addresses #3900 #3907

Merged
merged 1 commit into from
Jun 26, 2017
Merged

Adding default locale as en. Addresses #3900 #3907

merged 1 commit into from
Jun 26, 2017

Conversation

anilreddykatta
Copy link
Contributor

@anilreddykatta anilreddykatta commented Jun 25, 2017

Summary
Currently, we are reading locale information from language prop in Docs. When we don't pass the prop it treats as empty resulting in 404. I defaulted language to en when prop is not passed. Addresses #3900

Test plan

@anilreddykatta anilreddykatta changed the title Adding default locale as en. Addresses #3890 Adding default locale as en. Addresses #3900 Jun 25, 2017
@codecov-io
Copy link

Codecov Report

Merging #3907 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3907   +/-   ##
=======================================
  Coverage   58.01%   58.01%           
=======================================
  Files         195      195           
  Lines        6741     6741           
  Branches        6        6           
=======================================
  Hits         3911     3911           
  Misses       2827     2827           
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04d05e5...53f46e5. Read the comment docs.

@cpojer cpojer merged commit 5e28dda into jestjs:master Jun 26, 2017
@cpojer
Copy link
Member

cpojer commented Jun 26, 2017

Thanks!

tushardhole pushed a commit to tushardhole/jest that referenced this pull request Aug 21, 2017
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants