Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mocking for modules with folders on windows #4238

Merged
merged 1 commit into from
Aug 10, 2017

Conversation

KELiON
Copy link
Contributor

@KELiON KELiON commented Aug 10, 2017

Summary

Fixing #4014: mocks for packages with folders (like lodash/fp/sum) on Windows.

Questions

  1. what is the better way to write tests for that?
  2. Is this change enough? Doesn't it break something else on windows? There are not a lot for tests

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@cpojer
Copy link
Member

cpojer commented Aug 10, 2017

This works for me, do you mind running yarn lint -- --fix and pushing to this branch again?

@KELiON KELiON force-pushed the fix/windows-mocks branch from 6749126 to bc82ccc Compare August 10, 2017 15:36
@KELiON
Copy link
Contributor Author

KELiON commented Aug 10, 2017

@cpojer sure, done

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants